Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved asset details page #6256

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Improved asset details page #6256

merged 6 commits into from
Sep 19, 2023

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Sep 10, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 603a550

Refactored the AssetManage component to use the Page component and reorganized the asset details. Added a copy-to-clipboard feature for asset serial numbers and improved the expiry label in AssetWarrantyCard.

Proposed Changes

  • Fixes Asset Page: Improvements #6235
  • Moved export icon to the right corner of the screen
  • Changed asset type into a label
  • Added asset icon on the right side of the asset name and removed asset class from the info list
  • Added Copy to Clipboard button next to the serial number
  • Renamed "Expiry" to Warranty/AMC Expiry"

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 603a550

  • Replace PageTitle component with Page component to provide more features and consistency in AssetManage component (link, link, link, link)
  • Move export button to option button of Page component and add asset class icon and name as tooltip next to asset name in AssetManage component (link)
  • Display asset type as chip below asset name and remove asset type and asset class details from AssetDetailsCard component in AssetManage component (link, link)
  • Change label of warranty/amc expiry detail to be more descriptive and consistent in AssetWarrantyCard component (link)
  • Add button to copy serial number to clipboard and show feedback message in AssetWarrantyCard component (link, link, link)

@GokulramGHV GokulramGHV requested a review from a team September 10, 2023 06:46
@GokulramGHV GokulramGHV requested a review from a team as a code owner September 10, 2023 06:46
@vercel
Copy link

vercel bot commented Sep 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 8:29am

@netlify
Copy link

netlify bot commented Sep 10, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7a1401a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65095bd981750e00088912f9
😎 Deploy Preview https://deploy-preview-6256--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GokulramGHV GokulramGHV changed the title improved asset details page Improved asset details page Sep 10, 2023
@nihal467
Copy link
Member

nihal467 commented Sep 11, 2023 •
edited
Loading

@GokulramGHV

image

once we click on the copy icon, it shows copied to clipboard, We can't copy it again unless I refresh the page

Reset the state, after a second or so, the copy button appear again

image

in mobile view, keep the description below the asset name, similar to the view we have normal screen

image

The line separating the vendor and customer support heading is close to the vendor, so, move the line to a middle position in between the vendor and customer support

@nihal467
Copy link
Member

nihal467 commented Sep 11, 2023 •
edited
Loading

@aparnacoronasafe https://deploy-preview-6256--care-net.netlify.app/facility/1210229b-711a-46e6-ab0a-207c4808e32e/assets/fe3295e6-0893-4024-99a8-3f2b981ea1c6 , can you verify the UI

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 15, 2023
@github-actions
Copy link

👋 Hi, @GokulramGHV,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@GokulramGHV GokulramGHV added needs testing made_changes and removed changes required merge conflict pull requests with merge conflict labels Sep 16, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 97ed8ae into ohcnetwork:develop Sep 19, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
cypress passed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset Page: Improvements
3 participants
@GokulramGHV @nihal467 @khavinshankar